zturner accepted this revision.
zturner added a reviewer: zturner.
This revision is now accepted and ready to land.
================
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:60
@@ +59,3 @@
+ MinidumpParser parser(data_buf_sp, header, directory_map);
+ return llvm::Optional<MinidumpParser>(parser);
+}
----------------
You can just write `return parser` here. It's implicitly convertible to an
`llvm::Optional<>`.
================
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:65
@@ +64,3 @@
+ const llvm::DenseMap<uint32_t,
MinidumpLocationDescriptor> &directory_map)
+ : m_data_sp(data_buf_sp), m_header(header), m_directory_map(directory_map)
+{
----------------
This isn't really a performance critical class, so it doesn't matter too much,
but you could `std::move(directory_map)` to avoid the copy.
https://reviews.llvm.org/D23545
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
