dvlahovski added a comment. I changed all of the `llvm::Optional<const type *>` returning functions to return only `const type *` and signalize for 'failure' by returning a `nullptr`. In the cases where I return objects (e.g. vector of threads) I'm still using the `llvm::Optional` pattern. I also think that using `llvm::Error` is a good idea, but I think that it'll be difficult, because of collisions with the `lldb::Error`, and also at some point I have to convert objects from one type to the other.
So that's why I stick to the `llvm::Optional`. I also used it on the creation of `MinidumpParser` (following somewhat the pattern that you proposed) https://reviews.llvm.org/D23545 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
