On Sun, Jul 05, 2026 at 05:41:18PM -0500, Bjorn Andersson wrote: > On Fri, Jul 03, 2026 at 05:31:13AM -0700, Ananthu C V wrote: > > From: Sibi Sankar <[email protected]> > > > > The SoC Control Processor (SoCCP) is a small RISC-V MCU that controls > > USB Type-C, battery charging and various other functions on Qualcomm SoCs. > > This sounds like a good description of the SoCCP, excellent start of the > commit message. > > > It provides a solution for control-plane processing, reducing per-subsystem > > microcontroller reinvention. > > But, not only did the first sentence come to a full stop, this sentence > is also trying to describe the purpose of the SoCCP - but the scope > doesn't seem to overlap, so this seems to hint that there's more to it > than what was first established... > > Please fix. > > > Add PAS loader for SoCCP on Glymur DT. > > And once you have established the problem description across multiple > sentences, break the paragraph to give the reader some > breathing/thinking room, before documenting the "user-visible change" of > the patch. > > Regards, > Bjorn
ACK, will improve this commit message as well. Best, Ananthu
