Hi Krzysztof,
On Fri, Jul 03, 2026 at 02:44:41PM +0200, Krzysztof Kozlowski wrote:
> On 03/07/2026 14:31, Ananthu C V wrote:
> > Most Qualcomm platforms feature Gunyah hypervisor, which typically
> > handles Stage 2 IOMMU configuration. Additionally, SHM bridge setup
> > is required to enable memory protection for both remoteproc metadata
> > and its memory regions. When the aforementioned hypervisor is absent,
> > the operating system must perform these configurations instead. We've
> > been relying on the iommu property being present for this, but for
> > remoteprocs that are already running like SoCCP the mappings are already
> > in place, and any attempt to recreate them while active would lead to smmu
> > faults and a non-functional remoteproc. Fix this by adding a needs_tzmem
> > flag which ensures tzmem and SHM bridge setup is performed independent to
> > the iommu property being present.
>
> Looks awfully like LLM written and considering obvious problem, this
> feels vibe coded.
>
> According to current docs YOU SHOULD add vibe-coding tag to the commit
> when doing that.
Part of the commit message is based on 5c720260e840, and the rest is all written
and readjusted manually. Every single line of change in the code also is fully
handwritten - well, typed - by me. I don't know where the feeling came from, but
please be relieved to know that there has been no involvement of AI here.
> > static const struct of_device_id qcom_pas_of_match[] = {
> > { .compatible = "qcom,eliza-adsp-pas", .data = &sm8550_adsp_resource },
> > + { .compatible = "qcom,glymur-soccp-pas", .data = &glymur_soccp_resource
> > },
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
I ran checkpatch well over twenty times before posting the series, and I did
it a few more times after seeing your reply. I did not run into any problems,
and as such I cannot understand the problem here.
I could not paste this into an external pastebin from my work pc due to policy
reasons, so please forgive me for sharing this extended paste here:
$ git status
On branch next-20260702
nothing to commit, working tree clean
$ b4 shazam
https://lore.kernel.org/all/[email protected]/
Looking up
https://lore.kernel.org/all/[email protected]/
Grabbing thread from
lore.kernel.org/all/[email protected]/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 8 messages in the thread
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
✗ [PATCH v4 1/3] remoteproc: qcom: pas: add needs_tzmem flag to force
shmbridge creation
✗ [PATCH v4 2/3] arm64: dts: qcom: fix SoCCP memory mappings for Glymur
✗ [PATCH v4 3/3] arm64: dts: qcom: add SoCCP DT node for Glymur
---
✗ No key: ed25519/[email protected]
✓ Signed: DKIM/oss.qualcomm.com
---
Total patches: 3
---
Applying: remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge
creation
Applying: arm64: dts: qcom: fix SoCCP memory mappings for Glymur
Applying: arm64: dts: qcom: add SoCCP DT node for Glymur
$ git log -3 --oneline
3aec83c4ebd4 (HEAD -> next-20260702) arm64: dts: qcom: add SoCCP DT node for
Glymur
abb3c9998fbf arm64: dts: qcom: fix SoCCP memory mappings for Glymur
7a2db13e713d remoteproc: qcom: pas: add needs_tzmem flag to force shmbridge
creation
$ scripts/checkpatch.pl --strict -g HEAD~3..HEAD
-----------------------------------------------------------------------------------------------
Commit 7a2db13e713d ("remoteproc: qcom: pas: add needs_tzmem flag to force
shmbridge creation")
-----------------------------------------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 44 lines checked
Commit 7a2db13e713d ("remoteproc: qcom: pas: add needs_tzmem flag to force
shmbridge creation")
has no obvious style problems and is ready for submission.
------------------------------------------------------------------------------
Commit abb3c9998fbf ("arm64: dts: qcom: fix SoCCP memory mappings for Glymur")
------------------------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 17 lines checked
Commit abb3c9998fbf ("arm64: dts: qcom: fix SoCCP memory mappings for Glymur")
has no obvious
style problems and is ready for submission.
----------------------------------------------------------------------
Commit 3aec83c4ebd4 ("arm64: dts: qcom: add SoCCP DT node for Glymur")
----------------------------------------------------------------------
total: 0 errors, 0 warnings, 0 checks, 63 lines checked
Commit 3aec83c4ebd4 ("arm64: dts: qcom: add SoCCP DT node for Glymur") has no
obvious style
problems and is ready for submission.
> > { .compatible = "qcom,kaanapali-soccp-pas", .data =
> > &kaanapali_soccp_resource },
> > { .compatible = "qcom,milos-adsp-pas", .data = &sm8550_adsp_resource },
> > { .compatible = "qcom,milos-cdsp-pas", .data = &milos_cdsp_resource },
> >
>
>
> Best regards,
> Krzysztof
Thank you for the review.
Best,
Ananthu
