On 10/11/2025 12:35, Bryan O'Donoghue wrote:
On 09/11/2025 09:39, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>
Read C-PHY from the device-tree bus-type and save it into the csiphy
structure for later use.
For C-PHY, skip clock line configuration, as there is none.
Signed-off-by: David Heidelberg <[email protected]>
---
drivers/media/platform/qcom/camss/camss-csiphy.h | 2 ++
drivers/media/platform/qcom/camss/camss.c | 8 ++++++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.h b/
drivers/media/platform/qcom/camss/camss-csiphy.h
index 895f80003c441..8f7d0e4c73075 100644
--- a/drivers/media/platform/qcom/camss/camss-csiphy.h
+++ b/drivers/media/platform/qcom/camss/camss-csiphy.h
@@ -28,11 +28,13 @@ struct csiphy_lane {
/**
* struct csiphy_lanes_cfg - CSIPHY lanes configuration
+ * @cphy: true if C-PHY is used, false if D-PHY is used
* @num_data: number of data lanes
* @data: data lanes configuration
* @clk: clock lane configuration (only for D-PHY)
*/
struct csiphy_lanes_cfg {
+ bool cphy;
Should be an integer from
include/dt-bindings/phy/phy.h
- PHY_TYPE_DPHY
- PHY_TYPE_CPHY
this should be indicated in the dt and latched here.
Would it make sense to rather use the int from:
include/dt-bindings/media/video-interfaces.h
- MEDIA_BUS_TYPE_CSI2_CPHY
- MEDIA_BUS_TYPE_CSI2_DPHY
- ...
?
This one is always used with the endpoint bus-type.
David
---
bod
--
David Heidelberg
