On Tue, Feb 27, 2018 at 08:39:48PM +0100, Luca Barbato wrote: > On 27/02/2018 19:24, Kravchenko, Alexander wrote: > > > -----Original Message----- > > > From: libav-devel [mailto:[email protected]] On Behalf Of Luca > > > Barbato > > > Sent: Tuesday, February 27, 2018 8:10 PM > > > To: [email protected] > > > Subject: Re: [libav-devel] [PATCH] AMF SDK integration code cleanup: > > > remove writer_id option & move AMF_COMMON_OPTIONS out from > > > amfenc.h > > > > > > On 27/02/2018 14:59, Kravchenko, Alexander wrote:> If we use multiple > > > LibavWriter objects in one process, we will have > > > > duplication of output in avlib log. To prevent this scenario we > > > > should use one constant writer_id . > > > > > > Thanks for the explanation, I'm fine with this change now. > > > > What are the next steps? > > > > Are you going to submit patch? Or should I create new one, containing only > > this change? > > > > I'd wait ~24h so people could comment and then I'll merge your change, no > need to do more work on that :)
Please send fresh patches for review instead, there's too many issues with the current one to be able to guess what you plan to merge. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
