On 27/02/2018 19:24, Kravchenko, Alexander wrote:
-----Original Message-----
From: libav-devel [mailto:[email protected]] On Behalf Of Luca
Barbato
Sent: Tuesday, February 27, 2018 8:10 PM
To: [email protected]
Subject: Re: [libav-devel] [PATCH] AMF SDK integration code cleanup:
remove writer_id option & move AMF_COMMON_OPTIONS out from
amfenc.h
On 27/02/2018 14:59, Kravchenko, Alexander wrote:> If we use multiple
LibavWriter objects in one process, we will have
duplication of output in avlib log. To prevent this scenario we
should use one constant writer_id .
Thanks for the explanation, I'm fine with this change now.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
What are the next steps?
Are you going to submit patch? Or should I create new one, containing only this
change?
I'd wait ~24h so people could comment and then I'll merge your change,
no need to do more work on that :)
For the other change I guess mainly depends on how many other options
that are shared across hevc and h264 you'll expose in the future.
the patch with just the writer_id changed with the following message:
"
amf_enc: Remove the writer_id option
The writer id is a logger identifier and there is only one: av_log.
"
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
