This patch accmoplishes multiple unrelated things. Ideally you would submit one patch per change. Also, there is no explanation of why you are doing these changes in the commit message.
On Tue, Feb 27, 2018 at 10:34:27AM +0000, Kravchenko, Alexander wrote: > From 4d0efe3f5fd03db188f41d52ee9549a046939d1d Mon Sep 17 00:00:00 2001 > From: diamond88 <[email protected]> Looks like your Git is misconfigured, please set your name properly. > --- a/libavcodec/amfenc.h > +++ b/libavcodec/amfenc.h > @@ -151,8 +148,4 @@ extern const enum AVPixelFormat ff_amf_pix_fmts[]; > > -#define AMF_COMMON_OPTIONS \ > - { "log_to_dbg", "Enable AMF logging to debug output", > OFFSET(log_to_dbg), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE }, \ > - { "writer_id", "Enable AMF logging to writer id", > OFFSET(writer_id), AV_OPT_TYPE_STRING, { .str = "libavcodec" }, 0, 1, VE } \ > - > --- a/libavcodec/amfenc_h264.c > +++ b/libavcodec/amfenc_h264.c > > - AMF_COMMON_OPTIONS, > + { "log_to_dbg", "Enable AMF logging to debug output", > OFFSET(log_to_dbg) , AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE }, > > --- a/libavcodec/amfenc_hevc.c > +++ b/libavcodec/amfenc_hevc.c > @@ -92,7 +91,7 @@ static const AVOption options[] = { > > - AMF_COMMON_OPTIONS, > + { "log_to_dbg", "Enable AMF logging to debug output", > OFFSET(log_to_dbg) ,AV_OPT_TYPE_INT,{ .i64 = 0 }, 0, 1, VE }, Why is this an improvement? Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
