Diego Biurrun <[email protected]> writes: > On Tue, Jul 05, 2011 at 02:02:30AM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > None of the compiled binaries use any of libpostproc's symbols except >> > for trivial ones that print version information. Thus the dependency >> > yields no benefit and it is preferable to drop it. >> > >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -69,11 +69,13 @@ FFLIBS-$(CONFIG_AVDEVICE) += avdevice >> > FFLIBS-$(CONFIG_AVCODEC) += avcodec >> > -FFLIBS-$(CONFIG_POSTPROC) += postproc >> > FFLIBS-$(CONFIG_SWSCALE) += swscale >> > >> > FFLIBS := avutil >> > >> > +DIRS-$(CONFIG_POSTPROC) += postproc >> > +DIRS = $(DIRS-yes) $(FFLIBS) >> > + >> > @@ -107,7 +109,7 @@ SUBDIR := $(1)/ >> > include $(SRC_PATH)/$(1)/Makefile >> > endef >> > >> > -$(foreach D,$(FFLIBS),$(eval $(call DOSUBDIR,lib$(D)))) >> > +$(foreach D,$(DIRS),$(eval $(call DOSUBDIR,lib$(D)))) >> >> This won't work. DIRS is already used for something else and gets reset >> between those lines. > > I can assure you that it does work, I tested it. libpostproc gets built > and installed, as does the rest. > > The DOSUBDIR template gets expanded for all directories in DIRS first. > The call to RESET happens within the DOSUBDIR template, after expansion.
That's dodgy at best and highly confusing. I will not think further about this until I have more spare time, and neither shall you. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
