Diego Biurrun <[email protected]> writes:

> None of the compiled binaries use any of libpostproc's symbols except
> for trivial ones that print version information.  Thus the dependency
> yields no benefit and it is preferable to drop it.
> ---
>  Makefile   |    6 ++++--
>  cmdutils.c |    2 --
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9f7b436..7868d20 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -69,11 +69,13 @@ FFLIBS-$(CONFIG_AVDEVICE) += avdevice
>  FFLIBS-$(CONFIG_AVFILTER) += avfilter
>  FFLIBS-$(CONFIG_AVFORMAT) += avformat
>  FFLIBS-$(CONFIG_AVCODEC)  += avcodec
> -FFLIBS-$(CONFIG_POSTPROC) += postproc
>  FFLIBS-$(CONFIG_SWSCALE)  += swscale
>  
>  FFLIBS := avutil
>  
> +DIRS-$(CONFIG_POSTPROC) += postproc
> +DIRS                     = $(DIRS-yes) $(FFLIBS)
> +
>  DATA_FILES := $(wildcard $(SRC_PATH)/ffpresets/*.ffpreset)
>  
>  SKIPHEADERS = cmdutils_common_opts.h
> @@ -107,7 +109,7 @@ SUBDIR := $(1)/
>  include $(SRC_PATH)/$(1)/Makefile
>  endef
>  
> -$(foreach D,$(FFLIBS),$(eval $(call DOSUBDIR,lib$(D))))
> +$(foreach D,$(DIRS),$(eval $(call DOSUBDIR,lib$(D))))

This won't work.  DIRS is already used for something else and gets reset
between those lines.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to