> On Jan. 12, 2013, 11:45 a.m., Allan Anderson wrote: > > > Sorry, but I have to re-open this issue! > > > > > > Select a valid tag and the OK button will be enabled even if the schedule > > > name is empty. > > > > Paraphrasing Alvaro, it's a bit of a bag of worms here, still. I don't see > > entering just a tag enabling the OK button, but entering a tag and > > immediately > > clicking in the memo field does, and it also clears the tag. In fact, > > entering > > text in the tag field, then clicking any input widget in the transaction > > area, > > clears the tag, removes it from thr drop-down, and enables the OK button. > > With > > a new schedule, entering two characters in the memo field, then entering an > > amount, then adding a third memo character enables the OK button. > > > > I got the impression from Alvaro, "That area of code is a big mess. For > > example, it's what took longer to migrate and stabilize in KDE4. I'd say > > it's > > good enough for now.", he felt a more thorough rework was necessary. > > > > However, I knew there were other gremlins there, and am happy to take it > > further in the meantime. > > (from KMyMoney-devel mailing list)
As a break from tags, the "With a new schedule, entering two characters in the memo field, then entering an amount, then adding a third memo character enables the OK button." issue still lurks. It's not so straight forward and I haven't found a way to reproduce it - Allan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107714/#review25280 ----------------------------------------------------------- On Jan. 12, 2013, 12:07 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107714/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2013, 12:07 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > The problem as originally reported was that in Schedules view, the OK button > became enabled even though no schedule name had been entered. > > It was found that the button became enabled as soon as a payee was entered. > It was also found that this happened when an amount was entered. > > For "payee", line 753 of transactioneditor.cpp has - > "connect(payee,SIGNAL(textChanged(QString)),this,SLOT(slotUpdateButtonState()))", > and slotUpdateButtonState() has - > "emit transactionDataSufficient(isComplete(reason)", > and 'This signal is sent out whenever enough data is present to enter the > transaction into the ledger.' > > Similarly, for "amount", at line 826, the same line appears. > > As neither of these fields is a mandatory one, I believe they should not > affect the OK button status. So, as shown in the patch, I have temporarily > disabled these lines. I have done numerous tests of schedule creation and > editing, and manual entry and editing of transactions without any problem. > > The same area of code in transactioneditor.cpp has several more of these > possibly unneeded lines, although not affecting schedules. For instance, > even with these two lines out and with no mandatory fields completed, if a > payee is selected and the memo, tag field, next due date or status is edited, > the OK button again is enabled wrongly. > > I don't really see any valid reason for 'slotUpdateButtonState()' to be in > this section. What do the wise men think? > > > This addresses bug 311481. > http://bugs.kde.org/show_bug.cgi?id=311481 > > > Diffs > ----- > > kmymoney/dialogs/transactioneditor.cpp 8f6f06b > > Diff: http://git.reviewboard.kde.org/r/107714/diff/ > > > Testing > ------- > > Numerous tests of schedule creation and editing, and manual entry and editing > of transactions without any problem. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
