Hello Alessandro, once Allan push this, can you check it out and remove that line for tags too if needed?
Thanks! Regards, Alvaro On Wed, Jan 23, 2013 at 9:32 AM, Alessandro Russo <axel...@yahoo.it> wrote: > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107714/ > > Ship it! > > When I added the tags I followed as example the code for memo and payee > fields, so if that line of code was wrong for the memo and payee fields it > will be wrong also for the tag field. > > > - Alessandro > > On January 12th, 2013, 12:07 p.m. UTC, Allan Anderson wrote: > Review request for KMymoney. > By Allan Anderson. > > *Updated Jan. 12, 2013, 12:07 p.m.* > Description > > The problem as originally reported was that in Schedules view, the OK button > became enabled even though no schedule name had been entered. > > It was found that the button became enabled as soon as a payee was entered. > It was also found that this happened when an amount was entered. > > For "payee", line 753 of transactioneditor.cpp has - > "connect(payee,SIGNAL(textChanged(QString)),this,SLOT(slotUpdateButtonState()))", > and slotUpdateButtonState() has - > "emit transactionDataSufficient(isComplete(reason)", > and 'This signal is sent out whenever enough data is present to enter the > transaction into the ledger.' > > Similarly, for "amount", at line 826, the same line appears. > > As neither of these fields is a mandatory one, I believe they should not > affect the OK button status. So, as shown in the patch, I have temporarily > disabled these lines. I have done numerous tests of schedule creation and > editing, and manual entry and editing of transactions without any problem. > > The same area of code in transactioneditor.cpp has several more of these > possibly unneeded lines, although not affecting schedules. For instance, > even with these two lines out and with no mandatory fields completed, if a > payee is selected and the memo, tag field, next due date or status is edited, > the OK button again is enabled wrongly. > > I don't really see any valid reason for 'slotUpdateButtonState()' to be in > this section. What do the wise men think? > > Testing > > Numerous tests of schedule creation and editing, and manual entry and editing > of transactions without any problem. > > *Bugs: * 311481 <http://bugs.kde.org/show_bug.cgi?id=311481> > Diffs > > - kmymoney/dialogs/transactioneditor.cpp (8f6f06b) > > View Diff <http://git.reviewboard.kde.org/r/107714/diff/> > > _______________________________________________ > KMyMoney-devel mailing list > KMyMoney-devel@kde.org > https://mail.kde.org/mailman/listinfo/kmymoney-devel > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
