> On Jan. 23, 2013, 12:32 p.m., Alessandro Russo wrote: > > When I added the tags I followed as example the code for memo and payee > > fields, so if that line of code was wrong for the memo and payee fields it > > will be wrong also for the tag field. > > Allan Anderson wrote: > The patch I proposed takes care of the enabling of the OK button issues, > including those with TAGs, but I think you'll find that the other points I > raised may still exist. > > I'm just about to push this fix, so we'll soon see. > > Allan Anderson wrote: > Erm, there still is a problem with the OK button, to do with the amount > and memo fields, which I thought I'd fixed as part of the patch. I'll need > to look again. > > So far as Tags are concerned, I've assumed that they would function in > the same way as the payee field. Enter a new name, then move focus to > another field. A dialog pops up to ask if a new payee should be created. > With a new tag, however, when focus is moved to another field, the new name > is cleared and no popup appears. > > Whilst this may be what was intended, isn't it a bit inconsistent? >
Sorry, false alarm. I had to break off, and when I returned, I found there is not still a problem with the OK button, so far as I can see. I'd looked at the code and all the calls to slotUpdateButtonState() in that area had been removed. I started to think that it must be getting called from elsewhere, but it wasn't. I then realised that I could no longer produce that problem. So, what I had done, I don't now know, but possibly had reverted to a pre-patched version. Apologies again. The Tag issue still is there, and there is a variation. If I create a new tag, then select that in a new schedule, then click in another field, the selection disappears, both from the line-edit and from the drop-down. Clicking the red 'x' restores it to the drop-down, which gets us back to square one. - Allan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107714/#review26063 ----------------------------------------------------------- On Jan. 12, 2013, 12:07 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107714/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2013, 12:07 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > The problem as originally reported was that in Schedules view, the OK button > became enabled even though no schedule name had been entered. > > It was found that the button became enabled as soon as a payee was entered. > It was also found that this happened when an amount was entered. > > For "payee", line 753 of transactioneditor.cpp has - > "connect(payee,SIGNAL(textChanged(QString)),this,SLOT(slotUpdateButtonState()))", > and slotUpdateButtonState() has - > "emit transactionDataSufficient(isComplete(reason)", > and 'This signal is sent out whenever enough data is present to enter the > transaction into the ledger.' > > Similarly, for "amount", at line 826, the same line appears. > > As neither of these fields is a mandatory one, I believe they should not > affect the OK button status. So, as shown in the patch, I have temporarily > disabled these lines. I have done numerous tests of schedule creation and > editing, and manual entry and editing of transactions without any problem. > > The same area of code in transactioneditor.cpp has several more of these > possibly unneeded lines, although not affecting schedules. For instance, > even with these two lines out and with no mandatory fields completed, if a > payee is selected and the memo, tag field, next due date or status is edited, > the OK button again is enabled wrongly. > > I don't really see any valid reason for 'slotUpdateButtonState()' to be in > this section. What do the wise men think? > > > This addresses bug 311481. > http://bugs.kde.org/show_bug.cgi?id=311481 > > > Diffs > ----- > > kmymoney/dialogs/transactioneditor.cpp 8f6f06b > > Diff: http://git.reviewboard.kde.org/r/107714/diff/ > > > Testing > ------- > > Numerous tests of schedule creation and editing, and manual entry and editing > of transactions without any problem. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
