> On May 6, 2014, 9:01 a.m., Aurélien Gâteau wrote: > > I realized I left one code untouched: the KDOCTOOLS_ENABLE_HTMLHANDBOOK > > block. What should be done with it? The option is not documented: is it > > obsolete? If I understand it correctly, the code generates .html files in > > the source directory, and does not install them. Is this the intended > > behavior?
In the longer term, I think we do want to generate HTML and install that. This will allow reading the help in a webbrowser, on platforms/systems where khelpcenter is not installed. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57393 ----------------------------------------------------------- On May 6, 2014, 8:59 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118004/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 8:59 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > This is a big patch made of 4 commits (can provide them separately if > needed). This is similar to https://git.reviewboard.kde.org/r/117997/ but for > handbook and man pages. > > The patch includes a test cmake project which for now must be installed > separately because it relies on kdoctools to be already installed. I also > refreshed the code a bit, turning macros into functions and using > cmake_parse_arguments(). > > > Diffs > ----- > > KF5DocToolsMacros.cmake 51caf34 > tests/kdoctools_install-test/CMakeLists.txt PRE-CREATION > tests/kdoctools_install-test/po/es/docs/index.docbook PRE-CREATION > tests/kdoctools_install-test/po/es/docs/kioslave5/fooslave/index.docbook > PRE-CREATION > tests/kdoctools_install-test/po/es/docs/man-kjscmd.1.docbook PRE-CREATION > tests/kdoctools_install-test/po/fr/docs/index.docbook PRE-CREATION > tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118004/diff/ > > > Testing > ------- > > Tested with supplied test project. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
