> On May 6, 2014, 1:03 a.m., Luigi Toscano wrote: > > KF5DocToolsMacros.cmake, line 110 > > <https://git.reviewboard.kde.org/r/118004/diff/1/?file=271626#file271626line110> > > > > Does it work on Windows? (not sure how cmake deals with the different > > separator there). > > Also: the original code was a bit generic (it removed all the non-basic > > alphanumeric characters); it seems that a non-portable character (over 127) > > could potentially lead to an invalid target name. Not the case for KF5 > > stuff, but for 3rd-party, maybe. This is the reference I've found on valid > > target names; what do you think? > > > > http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html#tag_04_84_13_03
Good point, I recreated a function to generate a target name, partially based on the old code. - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/#review57363 ----------------------------------------------------------- On May 6, 2014, 10:56 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118004/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 10:56 a.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > This is a big patch made of 4 commits (can provide them separately if > needed). This is similar to https://git.reviewboard.kde.org/r/117997/ but for > handbook and man pages. > > The patch includes a test cmake project which for now must be installed > separately because it relies on kdoctools to be already installed. I also > refreshed the code a bit, turning macros into functions and using > cmake_parse_arguments(). > > > Diffs > ----- > > KF5DocToolsMacros.cmake 51caf34 > tests/kdoctools_install-test/CMakeLists.txt PRE-CREATION > tests/kdoctools_install-test/po-off/es/docs/index.docbook PRE-CREATION > > tests/kdoctools_install-test/po-off/es/docs/kioslave5/fooslave/index.docbook > PRE-CREATION > tests/kdoctools_install-test/po-off/fr/docs/index.docbook PRE-CREATION > tests/kdoctools_install-test/po-off/fr/docs/man-kjscmd.1.docbook > PRE-CREATION > tests/kdoctools_install-test/po/es/docs/index.docbook PRE-CREATION > tests/kdoctools_install-test/po/es/docs/kioslave5/fooslave/index.docbook > PRE-CREATION > tests/kdoctools_install-test/po/es/docs/man-kjscmd.1.docbook PRE-CREATION > tests/kdoctools_install-test/po/fr/docs/index.docbook PRE-CREATION > tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118004/diff/ > > > Testing > ------- > > Tested with supplied test project. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
