----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118004/ -----------------------------------------------------------
(Updated May 6, 2014, 10:56 a.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes ------- Fix potential issue with target names. Remove dead code. Repository: kdoctools Description ------- This is a big patch made of 4 commits (can provide them separately if needed). This is similar to https://git.reviewboard.kde.org/r/117997/ but for handbook and man pages. The patch includes a test cmake project which for now must be installed separately because it relies on kdoctools to be already installed. I also refreshed the code a bit, turning macros into functions and using cmake_parse_arguments(). Diffs (updated) ----- KF5DocToolsMacros.cmake 51caf34 tests/kdoctools_install-test/CMakeLists.txt PRE-CREATION tests/kdoctools_install-test/po-off/es/docs/index.docbook PRE-CREATION tests/kdoctools_install-test/po-off/es/docs/kioslave5/fooslave/index.docbook PRE-CREATION tests/kdoctools_install-test/po-off/fr/docs/index.docbook PRE-CREATION tests/kdoctools_install-test/po-off/fr/docs/man-kjscmd.1.docbook PRE-CREATION tests/kdoctools_install-test/po/es/docs/index.docbook PRE-CREATION tests/kdoctools_install-test/po/es/docs/kioslave5/fooslave/index.docbook PRE-CREATION tests/kdoctools_install-test/po/es/docs/man-kjscmd.1.docbook PRE-CREATION tests/kdoctools_install-test/po/fr/docs/index.docbook PRE-CREATION tests/kdoctools_install-test/po/fr/docs/man-kjscmd.1.docbook PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118004/diff/ Testing ------- Tested with supplied test project. Thanks, Aurélien Gâteau
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
