ahmadsamir added inline comments. INLINE COMMENTS
> meven wrote in kfontchooserdialog.cpp:93 > Shouldn't this be not commented IIUC, if a function is declared static inside the class body (e.g. in the header file), the static keyword can't be repeated when it's defined outside the class body. > kossebau wrote in kfontchooserdialog.cpp:97 > Is having dialog objects on the stack a good idea? > > What if the application gets closed while the dialog is open, would that not > crash? > > At least at some point people thought it was not a good idea, see > https://blogs.kde.org/node/3919 hmmm..... dfaure knows more about exec() and event loops more than me. @dfaure WDYT? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28122 To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
