dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS
> kfontchooserdialog.h:81 > + * > + * @param parent The parent widget of the dialog, if any. > + * @param flags Defines how the font chooser is displayed. Do @param need to be in order of the arguments? (I'm not sure) > ahmadsamir wrote in kfontchooserdialog.h:89 > Done. And I removed the fontList parameter altogether, it wasn't used, and > even QFontDialog doesn't have it. I think the need to set a specific font > list to display in a font selection dialog is pretty niche, I couldn't find a > single usage of it in lxr (even in stable-qt4 branch). > > Since the ctor parameters both have default values, I won't overload the ctor. Good call. I can't think of any use case for this. Maybe choosing an emoji font? But then how to know which of the installed fonts qualify... Yeah let's wait until there's actually a use case, if ever. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontdlg (branched from master) REVISION DETAIL https://phabricator.kde.org/D28122 To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
