ahmadsamir marked 3 inline comments as done.
ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in kfontchooserdialog.h:81
> Do @param need to be in order of the arguments? (I'm not sure)
They should be, it's more logical.
> dfaure wrote in kfontchooserdialog.h:89
> Good call. I can't think of any use case for this.
>
> Maybe choosing an emoji font? But then how to know which of the installed
> fonts qualify... Yeah let's wait until there's actually a use case, if ever.
emoji fonts... that would need a whole rewrite in a lot of places, starting at
QFontDatabase, so we'd have isSmoothlyScalable and isEmojiScalable, and maybe
isEmojiMonospace, just kidding.
(what's wrong with ":D" ":)" ";)" ":(" "\o/"? all fonts support them, and they
look cool :D).
REPOSITORY
R236 KWidgetsAddons
BRANCH
l-kfontdlg (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28122
To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven,
bport, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
