----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109551/#review29478 -----------------------------------------------------------
kpty/tests/kptyprocesstest.cpp <http://git.reviewboard.kde.org/r/109551/#comment21999> i don't think eating the sleep is a good idea. i'm sure i added it for a reason (in a previous life ^^). kpty/tests/kptyprocesstest.cpp <http://git.reviewboard.kde.org/r/109551/#comment21997> because it's completely broken ^^ kpty/tests/kptyprocesstest.cpp <http://git.reviewboard.kde.org/r/109551/#comment21998> the -c needs to be a separate argument. the quotes, backslashes and attempt at a newline are all garbage. - Oswald Buddenhagen On March 18, 2013, 7:54 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109551/ > ----------------------------------------------------------- > > (Updated March 18, 2013, 7:54 p.m.) > > > Review request for KDE Frameworks, kdelibs, David Faure, and Oswald > Buddenhagen. > > > Description > ------- > > Just a simple port of KPtyProcess away from using KProcess. > > > Diffs > ----- > > kpty/kptyprocess.h 5e0df96 > kpty/kptyprocess.cpp 015a58c > kpty/tests/kptyprocesstest.cpp 04990a0 > > Diff: http://git.reviewboard.kde.org/r/109551/diff/ > > > Testing > ------- > > builds and tests pass. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
