https://bugs.kde.org/show_bug.cgi?id=407153
Mauro Carvalho Chehab <mchehab+sams...@kernel.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://commits.kde.org/kaf |https://commits.kde.org/kaf
|feine/402cbee5e675cf795b619 |feine/2644cbf02ed39bb6b194b
|b834f92aac086972afc |c6b7935b069b5769364
--- Comment #17 from Mauro Carvalho Chehab <mchehab+sams...@kernel.org> ---
Git commit 2644cbf02ed39bb6b194bc6b7935b069b5769364 by Mauro Carvalho Chehab.
Committed on 04/05/2019 at 12:35.
Pushed by mauroc into branch 'master'.
vlc: with vlc 2.x, use vlcMedia for libvlc_MediaMetaChanged event
As reported by Wolfgang, the libVlc 2.x fix applied at
402cbee5e675 ("vlc: fix support for vlc 2.x") still have issues,
causing some troubles at least on audio CDs.
The root cause seems to be that, on vlc 2.x, the event
libvlc_MediaMetaChanged should be registered against the
vlcMedia instance, instead of vlcMediaPlayer instance.
Document that inside the code, as this is not obvious.
While the old way is still supported on vlc 3.x, I opted to
keep the code inside #ifs, as some day we'll drop support for
vlc 2.x, making the code simpler.
Also, since this event is registered aganst a vlcMedia object
and behaves different than when applied against a vlcMediaPlayer
object, I'm also using a different name there, in order to avoid
confusion.
Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org>
M +16 -4 src/backend-vlc/vlcmediawidget.cpp
https://commits.kde.org/kaffeine/2644cbf02ed39bb6b194bc6b7935b069b5769364
--
You are receiving this mail because:
You are watching all bug changes.
