https://bugs.kde.org/show_bug.cgi?id=407153
--- Comment #15 from Mauro Carvalho Chehab <mchehab+sams...@kernel.org> --- (In reply to Wolfgang Bauer from comment #13) > (In reply to Mauro Carvalho Chehab from comment #12) > > Git commit 402cbee5e675cf795b619b834f92aac086972afc by Mauro Carvalho > > Chehab. > > Committed on 03/05/2019 at 12:11. > > Pushed by mauroc into branch 'master'. > > > > vlc: fix support for vlc 2.x > > It seems that change was not fully correct. > > Playback works now, but I still get this error message: > This object event manager doesn't know about 'MediaMetaChanged' > events04-05-19 10:05:54.006 [Warning ] kaffeine.mediawidget: Cannot attach > event handler 0 > > (only problem I noticed is that AudioCD track changes are not notified to > the user anymore, there could be more though) > > I note that the 2.0.16 code in makePlay() called > libvlc_media_event_manager(vlcMedia) to get the eventManager, while the code > in the constructor calls libvlc_media_player_event_manager(vlcMediaPlayer). > And it seems the latter doesn't know about libvlc_MediaMetaChanged in vlc > 2.x, which I assume is also the reason that playback didn't work at all in > the first place... Gah, that looks a very confusing code at 2.x... Both vlcMedia and vlcMediaPlayer uses the same events enum and shares the same event handler, but it seems they actually have a different set of events, instead of sharing a common event list! Could you please check if the enclosed patch address the issues? I ended by adding a longer comment trying to explain the issue. That should help to keep this code working if we need to do other changes there. Also, in a matter of fact, we could simply remove the #if, as the code should also work fine on 3.x, but I opted to keep them, as this would make easier if some day we decide to remove support for 2.x. -- You are receiving this mail because: You are watching all bug changes.
