lct45 commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r661673686
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedDeserializer.java
##########
@@ -39,7 +39,10 @@ public ChangedDeserializer(final Deserializer<T> inner) {
@Override
public void setIfUnset(final Deserializer<Void> defaultKeyDeserializer,
final Deserializer<T> defaultValueDeserializer) {
Review comment:
This is what I mentioned in my main comment - these methods are
ultimately referenced from `MeteredKeyValueStore`, `MeteredSessionStore`, and
`MeteredWindowStore` in methods that have both `StateStoreContexts` and
`ProcessorContext`. We can change it so we pass in the context but we'd need
two sets of methods, one for state store contexts and one for processor
contexts. The reason i didn't go ahead and do that was because it seemed a
little messy, just a trade-off I guess. WDYT @mjsax? The other alternative I
thought of was making `processorContext` and `StateStoreContext` related so we
could only needed one set of functions but that ended up being a decently sized
refactor when I tried to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
