lct45 commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r646714882
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/SourceNode.java
##########
@@ -51,10 +52,16 @@ public SourceNode(final String name,
}
KIn deserializeKey(final String topic, final Headers headers, final byte[]
data) {
+ if (keyDeserializer == null) {
Review comment:
Ahh good catch, I did a check in `WrappingNullableUtils` for the
serializer but missed it for the deserializers somehow, I added it there and
removed this. Now we throw the config error when we try to build a topology
without a default or a serde passed in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
