mjsax commented on a change in pull request #10813:
URL: https://github.com/apache/kafka/pull/10813#discussion_r647929736
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java
##########
@@ -78,6 +79,10 @@
throw new StreamsException("Fatal user code error in
deserialization error callback", fatalUserException);
}
+ if (deserializationException instanceof ConfigException) {
Review comment:
My thought was, that for a `ConfigException` we are doomed to fail
anyway, and thus it seems not make sense to call the handler to allow the user
to "swallow" the exception by returning `CONTINUE` ?
Also, even if the user does return `CONTINUE`, it seems we could ignore it
and rethrow the `ConfigException` and die anyway, what seems to defeat the
purpose of (calling) the exception handler to begin with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
