squah-confluent commented on code in PR #21652:
URL: https://github.com/apache/kafka/pull/21652#discussion_r2896867372
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -1170,7 +1170,7 @@ public void
testStreamsGroupMemberCanRejoinWithEpochZero() {
TaskAssignmentTestUtil.mkTasksTuple(TaskRole.ACTIVE,
TaskAssignmentTestUtil.mkTasks(subtopology1, 0, 1, 2)
)));
-
context.replay(StreamsCoordinatorRecordHelpers.newStreamsGroupTargetAssignmentEpochRecord(groupId,
100));
+
context.replay(StreamsCoordinatorRecordHelpers.newStreamsGroupTargetAssignmentEpochRecord(groupId,
100, 12345L));
Review Comment:
I went with `12345L` for testing replays and `context.time.milliseconds()`
for expected records. Shall we use `context.time.milliseconds()` for all of
them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
