akhileshchg commented on code in PR #21652: URL: https://github.com/apache/kafka/pull/21652#discussion_r2898526641
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/TargetAssignmentMetadata.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group; + +/** + * The target assignment metadata. + * + * @param assignmentEpoch The target assignment epoch. An assignment epoch smaller than the + * group epoch means that a new assignment is required. The + * assignment epoch is updated when a new assignment is installed. + * @param assignmentTimestamp The time at which the target assignment calculation finished. + */ +public record TargetAssignmentMetadata(int assignmentEpoch, long assignmentTimestamp) { + public static final TargetAssignmentMetadata NONE = new TargetAssignmentMetadata(0, 0L); +} Review Comment: Nit: Should we safeguard the record from having negative/illegal values for epoch or timestamp? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
