chia7712 commented on code in PR #21652:
URL: https://github.com/apache/kafka/pull/21652#discussion_r2896594202
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsCoordinatorRecordHelpers.java:
##########
@@ -215,10 +215,18 @@ public static CoordinatorRecord
newStreamsGroupTargetAssignmentTombstoneRecord(
);
}
-
+ /**
+ * Creates a StreamsGroupTargetAssignmentMetadata record.
+ *
+ * @param groupId The streams group id.
+ * @param assignmentEpoch The assignment epoch.
+ * @param assignmentTimestamp The time at which the target assignment
calculation finished.
+ * @return The record.
+ */
public static CoordinatorRecord newStreamsGroupTargetAssignmentEpochRecord(
Review Comment:
ditto
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java:
##########
@@ -663,20 +666,23 @@ public static CoordinatorRecord
newShareGroupTargetAssignmentTombstoneRecord(
/**
* Creates a ShareGroupTargetAssignmentMetadata record.
*
- * @param groupId The group id.
- * @param assignmentEpoch The group epoch.
+ * @param groupId The group id.
+ * @param assignmentEpoch The group epoch.
+ * @param assignmentTimestamp The time at which the target assignment
calculation finished.
* @return The record.
*/
public static CoordinatorRecord newShareGroupTargetAssignmentEpochRecord(
Review Comment:
ditto
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java:
##########
@@ -45,6 +45,18 @@
*/
public abstract class ModernGroup<T extends ModernGroupMember> implements
Group {
+ /**
+ * The target assignment metadata.
+ *
+ * @param assignmentEpoch The target assignment epoch. An assignment
epoch smaller than the
+ * group epoch means that a new assignment is
required. The
+ * assignment epoch is updated when a new
assignment is installed.
+ * @param assignmentTimestamp The time at which the target assignment
calculation finished.
+ */
+ protected static record TargetAssignmentMetadata(int assignmentEpoch, long
assignmentTimestamp) {
Review Comment:
`static` is redundant
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java:
##########
@@ -235,20 +235,23 @@ public static CoordinatorRecord
newConsumerGroupTargetAssignmentTombstoneRecord(
/**
* Creates a ConsumerGroupTargetAssignmentMetadata record.
*
- * @param groupId The consumer group id.
- * @param assignmentEpoch The consumer group epoch.
+ * @param groupId The consumer group id.
+ * @param assignmentEpoch The consumer group epoch.
+ * @param assignmentTimestamp The time at which the target assignment
calculation finished.
* @return The record.
*/
public static CoordinatorRecord
newConsumerGroupTargetAssignmentEpochRecord(
String groupId,
- int assignmentEpoch
+ int assignmentEpoch,
+ long assignmentTimestamp
) {
return CoordinatorRecord.record(
new ConsumerGroupTargetAssignmentMetadataKey()
.setGroupId(groupId),
new ApiMessageAndVersion(
new ConsumerGroupTargetAssignmentMetadataValue()
- .setAssignmentEpoch(assignmentEpoch),
+ .setAssignmentEpoch(assignmentEpoch)
+ .setAssignmentTimestamp(assignmentTimestamp),
Review Comment:
Should we update the method naming to reflect this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
