chia7712 commented on code in PR #21652:
URL: https://github.com/apache/kafka/pull/21652#discussion_r2894573804
##########
group-coordinator/src/main/resources/common/message/ConsumerGroupTargetAssignmentMetadataValue.json:
##########
@@ -21,6 +21,9 @@
"flexibleVersions": "0+",
"fields": [
{ "name": "AssignmentEpoch", "versions": "0+", "type": "int32",
- "about": "The assignment epoch." }
+ "about": "The assignment epoch." },
+ // Added in 4.3 (KIP-1263).
+ { "name": "Timestamp", "versions": "0+", "taggedVersions": "0+", "tag": 0,
"type": "int64", "default": 0, "ignorable": true,
Review Comment:
Just wondering if we've discussed the timestamp's default value. Do you
think `-1` might be a better fit there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
