kirktrue commented on code in PR #21429:
URL: https://github.com/apache/kafka/pull/21429#discussion_r2819766663
##########
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgeType.java:
##########
@@ -46,7 +47,13 @@ public String toString() {
return super.toString().toLowerCase(Locale.ROOT);
}
-
+ /**
+ * Returns the AcknowledgeType for the given identifier.
+ *
+ * @param id the identifier for the acknowledge type
+ * @return the corresponding AcknowledgeType
+ * @throws IllegalArgumentException if the id is not recognized
Review Comment:
Can I be super picky and request that we capitalize the beginning of
sentences?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java:
##########
@@ -135,10 +141,22 @@ protected ConsumerRecord<K, V> makeNext() {
}
}
+ /**
+ * Returns whether this container has any records.
+ *
+ * @return true if there are no records, false otherwise
+ */
public boolean isEmpty() {
return records.isEmpty();
}
+ /**
+ * Returns an empty ConsumerRecords instance.
Review Comment:
Unrelated to this change, but I'm wondering if this method is useful to
users, or if it's only used internally 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
