lianetm commented on code in PR #21429:
URL: https://github.com/apache/kafka/pull/21429#discussion_r2816648598
##########
clients/src/main/java/org/apache/kafka/clients/consumer/RetriableCommitFailedException.java:
##########
@@ -18,19 +18,42 @@
import org.apache.kafka.common.errors.RetriableException;
+/**
+ * Exception thrown when an offset commit fails with a retriable error.
+ * <p>
+ * Unlike {@link CommitFailedException}, this exception indicates that the
commit
+ * can be retried. The consumer should attempt to commit the offsets again.
+ * </p>
+ */
public class RetriableCommitFailedException extends RetriableException {
Review Comment:
May be helpful to mention that this exception is generated on the client
side, when receiving retriable errors from the GC on commit.
The point is to call out the diff with exceptions that come from the GC
(mapped as error codes in responses)
##########
clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java:
##########
@@ -18,6 +18,17 @@
import java.util.Locale;
+/**
+ * Enum representing the consumer group protocol type.
+ * <p>
+ * Kafka supports two types of consumer group protocols:
Review Comment:
nit: simplify/combine
```suggestion
* Enum representing the supported consumer group protocols.
```
##########
clients/src/main/java/org/apache/kafka/clients/consumer/GroupProtocol.java:
##########
@@ -18,6 +18,17 @@
import java.util.Locale;
+/**
+ * Enum representing the consumer group protocol type.
+ * <p>
+ * Kafka supports two types of consumer group protocols:
+ * </p>
+ * <ul>
+ * <li>{@link #CLASSIC} - The original consumer group protocol</li>
+ * <li>{@link #CONSUMER} - The consumer group protocol introduced in Kafka
4.0 (KIP-848)</li>
Review Comment:
well it was introduced in 3.7 really (EA), then GA in 4.0
We can maybe just say this is the Consumer rebalance protocol (KIP-848) and
the other one is the Classic one (pre KIP-848) ?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/CommitFailedException.java:
##########
@@ -28,10 +28,18 @@ public class CommitFailedException extends KafkaException {
private static final long serialVersionUID = 1L;
+ /**
+ * Constructs a new CommitFailedException with the specified detail
message.
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
