zooo-code commented on code in PR #21429:
URL: https://github.com/apache/kafka/pull/21429#discussion_r2819734276
##########
clients/src/main/java/org/apache/kafka/clients/consumer/RetriableCommitFailedException.java:
##########
@@ -18,19 +18,42 @@
import org.apache.kafka.common.errors.RetriableException;
+/**
+ * Exception thrown when an offset commit fails with a retriable error.
+ * <p>
+ * Unlike {@link CommitFailedException}, this exception indicates that the
commit
+ * can be retried. The consumer should attempt to commit the offsets again.
+ * </p>
+ */
public class RetriableCommitFailedException extends RetriableException {
Review Comment:
I've clarified that this exception is generated on the client side based on
the Group Coordinator's response.
Thanks!
##########
clients/src/main/java/org/apache/kafka/clients/consumer/CommitFailedException.java:
##########
@@ -28,10 +28,18 @@ public class CommitFailedException extends KafkaException {
private static final long serialVersionUID = 1L;
+ /**
+ * Constructs a new CommitFailedException with the specified detail
message.
Review Comment:
Done. Applied the same clarification here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
