Copilot commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2383114279
##########
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##########
@@ -255,10 +256,10 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness {
Optional.empty(),
util.Map.of(
"subtopology-0", new StreamsRebalanceData.Subtopology(
- util.Set.of(inputTopic),
+ inputTopics.asJava,
util.Set.of(),
util.Map.of(),
- util.Map.of(inputTopic + "-store-changelog", new
StreamsRebalanceData.TopicInfo(Optional.of(1), Optional.empty(),
util.Map.of())),
+ changelogTopics.map(c => (c, new
StreamsRebalanceData.TopicInfo(Optional.empty(), Optional.empty(),
util.Map.of()))).toMap.asJava,
Review Comment:
The TopicInfo constructor is called with `Optional.empty()` for the
partition count parameter, but the original code used `Optional.of(1)`. This
change may break functionality that depends on having a specific partition
count.
```suggestion
changelogTopics.map(c => (c, new
StreamsRebalanceData.TopicInfo(Optional.of(1), Optional.empty(),
util.Map.of()))).toMap.asJava,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
