mjsax commented on code in PR #20457:
URL: https://github.com/apache/kafka/pull/20457#discussion_r2331706320
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6005,7 +6010,13 @@ public void replay(
if (value == null) {
// Tombstone. Group should be removed.
- removeGroup(groupId);
+ // In case of streams groups, which get inserted into memory
immediately to store soft state,
+ // It may happen that the groups map contains the new streams
groups already, and the classic group
+ // was removed already. In this case, we can ignore the tombstone.
Review Comment:
> The alternative to this fix would be to change the records in the KIP to
also persist configuredTopology. We can discuss if this is a way we want to go
at this point.
My first impression is, that this would be cleaner? I am sure, there was
good reasons to not update the soft-state directly. Maybe @dajac can comment?
How much work would it be to persist and re-read `ConfiguredTopology`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
