lucasbru commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2382504677
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4223,7 +4232,7 @@ private <T> CoordinatorResult<T, CoordinatorRecord>
streamsGroupFenceMember(
// We bump the group epoch.
int groupEpoch = group.groupEpoch() + 1;
- records.add(newStreamsGroupEpochRecord(group.groupId(), groupEpoch,
0));
+ records.add(newStreamsGroupMetadataRecord(group.groupId(), groupEpoch,
group.metadataHash(), group.validatedTopologyEpoch()));
Review Comment:
There was a bug here - every time we'd fence a member, we'd reset the
metadata hash to 0. We don't need to do that, otherwise we'll need to recompute
the metadata hash on the next heartbeat and bump the group epoch again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
