josefk31 commented on code in PR #19664:
URL: https://github.com/apache/kafka/pull/19664#discussion_r2114801199
##########
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##########
@@ -134,8 +134,8 @@ public enum ApiKeys {
STREAMS_GROUP_DESCRIBE(ApiMessageType.STREAMS_GROUP_DESCRIBE),
DESCRIBE_SHARE_GROUP_OFFSETS(ApiMessageType.DESCRIBE_SHARE_GROUP_OFFSETS),
ALTER_SHARE_GROUP_OFFSETS(ApiMessageType.ALTER_SHARE_GROUP_OFFSETS),
- DELETE_SHARE_GROUP_OFFSETS(ApiMessageType.DELETE_SHARE_GROUP_OFFSETS);
-
+ DELETE_SHARE_GROUP_OFFSETS(ApiMessageType.DELETE_SHARE_GROUP_OFFSETS),
+ GET_REPLICA_LOG_INFO(ApiMessageType.GET_REPLICA_LOG_INFO, true);
Review Comment:
This does not need to be a `clusterAction` but keeping it that way makes
handling authentication easier to implement as I'd argue we would have to
follow the same ACLs model as `fetch` requests.
It could be something which is added in future IMO.
It seems like throttling is enabled based on `clientId` which would be
whatever broker/controller on cluster is sending these requests which is why I
needed to add this
[exception](https://github.com/apache/kafka/pull/19664/files#r2114220408).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
