josefk31 commented on code in PR #19664:
URL: https://github.com/apache/kafka/pull/19664#discussion_r2114220408
##########
core/src/test/scala/unit/kafka/server/RequestQuotaTest.scala:
##########
@@ -163,7 +163,7 @@ class RequestQuotaTest extends BaseRequestTest {
@Test
def testExemptRequestTime(): Unit = {
// Exclude `DESCRIBE_QUORUM`, maybe it shouldn't be a cluster action
- val actions = clusterActions -- clusterActionsWithThrottleForBroker --
RequestQuotaTest.Envelope -- RequestQuotaTest.ShareGroupState -
ApiKeys.DESCRIBE_QUORUM
+ val actions = clusterActions -- clusterActionsWithThrottleForBroker --
RequestQuotaTest.Envelope -- RequestQuotaTest.ShareGroupState -
ApiKeys.DESCRIBE_QUORUM - ApiKeys.GET_REPLICA_LOG_INFO
Review Comment:
Yes that is correct, with this one I followed the recent pattern and the
KIP-966 specification. The KIP specifies that the request has throttling and
recent cluster actions are also throttled.
I think having throttling does "make sense" in this case - IG its best to
avoid asking brokers too many questions about their logs if they are
overwhelmed with requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
