josefk31 commented on PR #19664: URL: https://github.com/apache/kafka/pull/19664#issuecomment-2898498747
> > We need a boolean to indicate that there is more data that we were unable to send due to length restrictions > > I wonder if it is good enough to indicate the limit is reached when the partition is missing from the response? Especially, we use an explicit partition list in the request. @cmccabe @CalvinConfluent I think we're dealing with the following tradeoffs: 1. We want to save space on RPCs 2. We want to reduce processing time on the brokers 3. RPC should be predictable It's more obvious what the RPC is doing if we return an error code for sure. That being said; I think it does not address (1) completely. I think that the `Truncate` is balancing (1) and (2) at the expense of (3) being a bit less clear. It's still fairly straightforward that we return the first 1k requested and set `Truncate` to true and requires a consumer of the API to read the API definition. But since this is a cluster-action I feel that the confusion is fair to impose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
