jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765383672
########## config/kraft/reconfig-server.properties: ########## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: > It's unclear why we're adding a new file This file is reference in Dockerfile and a few other places. I haven't had a chance to fix all of those places to use kraft.version 0. I instead created this jira: https://issues.apache.org/jira/browse/KAFKA-17576 ```bash rg "kraft\/server.properties" docker/native/Dockerfile 66:COPY --chown=appuser:root --from=build-native-image /app/kafka/config/kraft/server.properties /etc/kafka/docker/ docker/docker_official_images/3.7.0/jvm/Dockerfile 81: cp /opt/kafka/config/kraft/server.properties /etc/kafka/docker/server.properties; \ docker/docker_official_images/3.7.0/jvm/jsa_launch 20:KAFKA_JVM_PERFORMANCE_OPTS="-XX:ArchiveClassesAtExit=storage.jsa" opt/kafka/bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c opt/kafka/config/kraft/server.properties 22:KAFKA_JVM_PERFORMANCE_OPTS="-XX:ArchiveClassesAtExit=kafka.jsa" opt/kafka/bin/kafka-server-start.sh opt/kafka/config/kraft/server.properties & docker/jvm/Dockerfile 81: cp /opt/kafka/config/kraft/server.properties /etc/kafka/docker/server.properties; \ docker/jvm/jsa_launch 20:KAFKA_JVM_PERFORMANCE_OPTS="-XX:ArchiveClassesAtExit=storage.jsa" opt/kafka/bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c opt/kafka/config/kraft/server.properties 22:KAFKA_JVM_PERFORMANCE_OPTS="-XX:ArchiveClassesAtExit=kafka.jsa" opt/kafka/bin/kafka-server-start.sh opt/kafka/config/kraft/server.properties & docs/streams/quickstart.html 133:<pre><code class="language-bash">$ bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c config/kraft/server.properties</code></pre> 139:<pre><code class="language-bash">$ bin/kafka-server-start.sh config/kraft/server.properties</code></pre> README.md 98: ./bin/kafka-storage.sh format -t $KAFKA_CLUSTER_ID -c config/kraft/server.properties 99: ./bin/kafka-server-start.sh config/kraft/server.properties ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
