jsancio commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1765336554
##########
docs/quickstart.html:
##########
@@ -50,46 +50,47 @@ <h5>Kafka with KRaft</h5>
<p>Kafka can be run using KRaft mode using local scripts and
downloaded files or the docker image. Follow one of the sections below but not
both to start the kafka server.</p>
- <h5>Using downloaded files</h5>
+ <h6>Using downloaded files</h6>
<p>Generate a Cluster UUID</p>
- <pre><code class="language-bash">$
KAFKA_CLUSTER_ID="$(bin/kafka-storage.sh random-uuid)"</code></pre>
+ <pre><code
class="language-bash">KAFKA_CLUSTER_ID="$(bin/kafka-storage.sh
random-uuid)"</code></pre>
<p>Format Log Directories</p>
- <pre><code class="language-bash">$ bin/kafka-storage.sh format -t
$KAFKA_CLUSTER_ID -c config/kraft/server.properties</code></pre>
+ <pre><code class="language-bash">bin/kafka-storage.sh format
--standalone -t $KAFKA_CLUSTER_ID -c
config/kraft/reconfig-server.properties</code></pre>
Review Comment:
I document --initial-controllers in ops.html. I don't think we should use
--initial-controllers in the quickstart for two reasons. It complicates the
quick start because the user will have to generate another uuid for the
controller's directory id instead of relying on the `kafka-storage` tool to
safely generate the directory id.
As explain in another comment and in ops.html, the safest and most
consistent way to bootstrap a cluster with many controllers is to use
--standalone on one of the controller and `kafka-metadata-quorum
add-controller` to add the rest of the controllers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
