cmccabe commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1759199331
########## config/kraft/broker.properties: ########## @@ -26,8 +26,8 @@ process.roles=broker # The node id associated with this instance's roles node.id=2 -# The connect string for the controller quorum -controller.quorum.voters=1@localhost:9093 Review Comment: We still support static quorum, and will for a while. I would suggest commenting the line with `controller.quorum.voters` out, and adding a comment saying that you should comment out either `controller.quorum.voters` or `controller.quorum.bootstrap.servers`, depending on whether you want to use a KIP-853 dynamic quorum or not. (By default, the uncommented one can be `controller.quorum.bootstrap.servers`, so that more people try the new thing.) ########## config/kraft/controller.properties: ########## @@ -26,13 +26,13 @@ process.roles=controller # The node id associated with this instance's roles node.id=1 -# The connect string for the controller quorum Review Comment: We still support static quorum, and will for a while. I would suggest commenting the line with `controller.quorum.voters` out, and adding a comment saying that you should comment out either `controller.quorum.voters` or `controller.quorum.bootstrap.servers`, depending on whether you want to use a KIP-853 dynamic quorum or not. (By default, the uncommented one can be `controller.quorum.bootstrap.servers`, so that more people try the new thing.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
