lianetm commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1761932369
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -2479,23 +2487,29 @@ public void testCurrentLag(GroupProtocol groupProtocol)
{
consumer.seek(tp0, 50L);
consumer.poll(Duration.ofMillis(0));
// requests: list-offset, fetch
- assertEquals(2, client.inFlightRequestCount());
Review Comment:
Hey @FrankYang0529, this testCurrentLag still seems flaky even after the
latest changes, I filed https://issues.apache.org/jira/browse/KAFKA-17560 with
what I see and where I imagine the flakiness may be, but it needs more thinking
probably. Here's a suggestion to make progress:
- we could leave `testCurrrentLag` disabled for the new consumer on this PR
(just as it was before)
- we unblock the other 2 tests, that seems to pass consistently after your
changes
- we address `testCurrentLag` in a separate PR, with that jira I created
(including the changes you had here, just that I think it needs more)
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
