FrankYang0529 commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1747137112
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -2507,32 +2521,35 @@ public void testCurrentLag(GroupProtocol groupProtocol)
{
assertEquals(OptionalLong.of(45L), consumer.currentLag(tp0));
}
- // TODO: this test triggers a bug with the CONSUMER group protocol
implementation.
- // The bug will be investigated and fixed so this test can use both
group protocols.
@ParameterizedTest
- @EnumSource(value = GroupProtocol.class, names = "CLASSIC")
+ @EnumSource(GroupProtocol.class)
public void testListOffsetShouldUpdateSubscriptions(GroupProtocol
groupProtocol) {
final ConsumerMetadata metadata = createMetadata(subscription);
final MockClient client = new MockClient(time, metadata);
initMetadata(client, singletonMap(topic, 1));
- consumer = newConsumer(groupProtocol, time, client, subscription,
metadata, assignor, true, groupInstanceId);
-
+ consumer = newConsumer(groupProtocol, time, client, subscription,
metadata, assignor, false,
+ null, groupInstanceId, false);
consumer.assign(singleton(tp0));
-
- // poll once to update with the current metadata
- consumer.poll(Duration.ofMillis(0));
- client.respond(FindCoordinatorResponse.prepareResponse(Errors.NONE,
groupId, metadata.fetch().nodes().get(0)));
-
consumer.seek(tp0, 50L);
- client.prepareResponse(listOffsetsResponse(singletonMap(tp0, 90L)));
+ client.prepareResponse(listOffsetsResponse(singletonMap(tp0, 90L)));
Review Comment:
Hi @lianetm and @TaiJuWu, thanks for the suggestion, but I think we can keep
this line just before `consumer.endOffsets`.
In `AsyncKafkaConsumer#endOffsets`, it sends `ListOffsetsEvent` and
`ApplicationEventProcessor#process(ListOffsetsEvent)` calls
`OffsetsRequestManager#fetchOffsets`.
In `OffsetsRequestManager#fetchOffsets`, it builds the request and
`AsyncKafkaConsumer#endOffsets` uses `ApplicationEventHandler#addAndGet` to
wait for the result, so I think it's safe to put it just before
`consumer.endOffsets`. WDYT? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
