FrankYang0529 commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1754351703
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -2479,23 +2487,29 @@ public void testCurrentLag(GroupProtocol groupProtocol)
{
consumer.seek(tp0, 50L);
consumer.poll(Duration.ofMillis(0));
// requests: list-offset, fetch
- assertEquals(2, client.inFlightRequestCount());
Review Comment:
Hi @lianetm, thanks for catching this. I tried to add `Thread.sleep(1000)`
before `assertEquals(0, client.inFlightRequestCount())`. It looks like both
`ListOffsetsRequest` and `OffsetFetchRequest` will be sent after getting
`FindCoordinatorResponse`. I remove the assertion now. Do you think that we
should keep this assertion for CLASSIC group protocol only? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
