kirktrue commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1759547587
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1709,6 +1715,10 @@ private void updateLastSeenEpochIfNewer(TopicPartition
topicPartition, OffsetAnd
offsetAndMetadata.leaderEpoch().ifPresent(epoch ->
metadata.updateLastSeenEpochIfNewer(topicPartition, epoch));
}
+ private void sendFetches(Timer timer) {
+ applicationEventHandler.addAndGet(new
FetchEvent(calculateDeadlineMs(timer)));
Review Comment:
I started off renaming it as `SendFetch` but then that didn't seem right
because the event doesn't directly send anything, either. Then I named it
`GenerateFetchRequestsEvents`, which is... not good. I settled on
`CreateFetchRequestsEvents` because that's exactly what it does.
I am not _too_ worried about the name, so if you really prefer `SendFetch` I
can keep it as that.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
