lianetm commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1757113701
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##########
@@ -65,16 +67,59 @@ protected void maybeThrowAuthFailure(Node node) {
networkClientDelegate.maybeThrowAuthFailure(node);
}
+ /**
+ * Request that a fetch request be issued to the cluster to pull down the
next batch of records.
+ *
+ * <p/>
+ *
+ * The returned {@link CompletableFuture} is {@link
CompletableFuture#complete(Object) completed} when the
+ * fetch request(s) have been created and enqueued into the network
client's outgoing send buffer.
Review Comment:
To be accurate, it completes when the fetch request has been generated, not
yet enqueued really (because it completes on the finally clause on the
manager.poll, and the generated request will be enqueued later on, after all
managers are polled), is my understanding correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
