lianetm commented on code in PR #17035:
URL: https://github.com/apache/kafka/pull/17035#discussion_r1757127937
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1709,6 +1715,10 @@ private void updateLastSeenEpochIfNewer(TopicPartition
topicPartition, OffsetAnd
offsetAndMetadata.leaderEpoch().ifPresent(epoch ->
metadata.updateLastSeenEpochIfNewer(topicPartition, epoch));
}
+ private void sendFetches(Timer timer) {
+ applicationEventHandler.addAndGet(new
FetchEvent(calculateDeadlineMs(timer)));
Review Comment:
this new event is really about `SendFetch` (not actual fetching), so maybe
it makes the intention clearer if we rename it, aligned with the sendFetches
func that creates it? Maybe me but reading FetchEvent here makes me go to the
AppEventProcessor to make sure that we're not fetching/blocking there :) and
it's only for sending the request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
