frankvicky commented on code in PR #16878:
URL: https://github.com/apache/kafka/pull/16878#discussion_r1721697187
##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -470,6 +470,22 @@ public void
shouldResetToDefaultIfRestoreConsumerAutoCommitIsOverridden() {
assertEquals("false",
consumerConfigs.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG));
}
+ @Test
+ public void shouldResetToDefaultIfConsumerGroupProtocolIsOverridden() {
+
props.put(StreamsConfig.consumerPrefix(ConsumerConfig.GROUP_PROTOCOL_CONFIG),
"classic,consumer");
Review Comment:
Hello @lucasbru
Thank you for pointing that out. After double-checking the documentation, I
realized that you’re absolutely right—"classic,consumer" is not a valid value
in a common consumer config. I appreciate your attention to detail.
I’ll update the test case. Thanks again for your valuable feedback! 🙇🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
