lucasbru commented on code in PR #16878:
URL: https://github.com/apache/kafka/pull/16878#discussion_r1721297070
##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -470,6 +470,22 @@ public void
shouldResetToDefaultIfRestoreConsumerAutoCommitIsOverridden() {
assertEquals("false",
consumerConfigs.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG));
}
+ @Test
+ public void shouldResetToDefaultIfConsumerGroupProtocolIsOverridden() {
+
props.put(StreamsConfig.consumerPrefix(ConsumerConfig.GROUP_PROTOCOL_CONFIG),
"classic,consumer");
Review Comment:
nit: "classic,consumer" is not a valid value for the config is it? THat's a
bit confusing, maybe I would just use "consumer"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
