frankvicky commented on code in PR #16878:
URL: https://github.com/apache/kafka/pull/16878#discussion_r1721311414
##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -470,6 +470,22 @@ public void
shouldResetToDefaultIfRestoreConsumerAutoCommitIsOverridden() {
assertEquals("false",
consumerConfigs.get(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG));
}
+ @Test
+ public void shouldResetToDefaultIfConsumerGroupProtocolIsOverridden() {
+
props.put(StreamsConfig.consumerPrefix(ConsumerConfig.GROUP_PROTOCOL_CONFIG),
"classic,consumer");
Review Comment:
Hello @lucasbru,
Thanks for the review 🙇🏼.
In this test case, we aim to ensure that the group protocol is not
overridden. The value "classic,consumer" is used here to verify that even if
the user provides a valid protocol (valid in a common consumer config, but not
in Kafka Streams), it will still be reset to "classic".
If this might cause confusion, I think adding a comment to clarify would be
a good idea.
WYDT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
